Kondor+ Adaptor Code Check List

NO  Details  Comments 
1  Does the all of the funcationality have been implemented?
* refer the elaboration document about the design verification section
* does NEW/MODIFICATION/CANCEL flow have been covered.  func 
2  does complex logic have comments?  code 
3  Is code commented if it's udpated  code 
4  Is there any wrong comments in code?  code 
5  Is variable clared as final as many as you can  code 
6  does un-necessary code/interface/functionaly exists?
If exists, does it been commented clearly about it?  code 
7  Did you check all of the message flow in log file even for a happy path?  log 
8  Have all of the key part of the code been unit tested?  UT 
9  does all of the error handling table case have been tested?  UT 
10  does all of the functions in mapping have been unit tested?  UT 
11  does all the test passed both 2.6 and 3.0?  K+ 
12  does all the deal translated can be seen from the blotter of kondor+?  K+ 
13  Is the case considered that the deal has already processed by K+ by checking the reference,lbn_confirmation,… in the method of OnDealRecord for the query/request result.
There should be a uniformed behavior for K+ Adapter.
XXXXDealHandler::OnDealRecord should be responsible for it. It's not put into the DealHandler to make it back-compatible. It's more flexible but error-prone.  Special Case 
14  Is error handling rule followed?  func